[PATCH] D140654: [MC] Use MCRegister instead of unsigned in MCInstPrinter (NFC)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/MC/MCInstPrinter.h:12
 
+#include "llvm/MC/MCRegister.h"
 #include "llvm/Support/Format.h"
----------------
barannikov88 wrote:
> craig.topper wrote:
> > Can this be a forward reference?
> Nope, it is passed by value in `printRegName` below (and also in generated `getRegisterName`).
> 
I thought the forward reference would be ok since only the declaration of printRegName is here. Isn’t it only needed for the definition and the call sites?

It’s late here so I might not be thinking clearly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140654/new/

https://reviews.llvm.org/D140654