[PATCH] D140463: [OpenMP] Merge barrier elimination into AAExecutionDomain

[Jose Manuel Monsalve Diaz via Phabricator via llvm-commits]

josemonsalve2 added a comment.

Minor things



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:167
 /// Flags to distinguish intra-procedural queries from *potentially*
 /// inter-procedural queries. Not that information can be valid for both and
 /// therefore both bits might be set.
----------------
I know this is unrelated, but probably a good chance to fix that typo


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:810
+
+    LLVM_DEBUG(dbgs() << "[AA] Access to '" << *Obj << "' requires barrier\n");
+    return true;
----------------
To be consistent with the other dbgs()


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:2931
+        // Record how we entered the call, then accumulate the effect of the
+        // call in EDf or potential use by the callee.
+        auto &CallED = CEDMap[CB];
----------------
I think. please check


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140463/new/

https://reviews.llvm.org/D140463