[PATCH] D141776: [X86] `X86TargetLowering`: override `allowsMemoryAccess()`

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 14 13:18:51 PST 2023


lebedev.ri created this revision.
lebedev.ri added reviewers: RKSimon, spatel, pengfei.
lebedev.ri added a project: LLVM.
Herald added subscribers: StephenFan, hiraditya.
Herald added a project: All.
lebedev.ri requested review of this revision.

We have a very picky set of rules regarding non-temporal memory ops,
and the baseline implementation basically conflicts with our `allowsMisalignedMemoryAccesses()`

I'm not quite sure how to better demonstrate the behavioral changes
given this change itself, but in a follow-up patch,
we'd otherwise endlessly combine.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141776

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.h
  llvm/test/CodeGen/X86/add-sub-bool.ll
  llvm/test/CodeGen/X86/bswap-wide-int.ll
  llvm/test/CodeGen/X86/fshl.ll
  llvm/test/CodeGen/X86/fshr.ll
  llvm/test/CodeGen/X86/i128-add.ll
  llvm/test/CodeGen/X86/icmp-shift-opt.ll
  llvm/test/CodeGen/X86/legalize-shl-vec.ll
  llvm/test/CodeGen/X86/merge-consecutive-stores-nt.ll
  llvm/test/CodeGen/X86/setcc-wide-types.ll
  llvm/test/CodeGen/X86/smin.ll
  llvm/test/CodeGen/X86/smul-with-overflow.ll
  llvm/test/CodeGen/X86/smulo-128-legalisation-lowering.ll
  llvm/test/CodeGen/X86/umin.ll
  llvm/test/CodeGen/X86/umul-with-overflow.ll
  llvm/test/CodeGen/X86/wide-integer-cmp.ll
  llvm/test/CodeGen/X86/xaluo128.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141776.489312.patch
Type: text/x-patch
Size: 44695 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230114/e567dfd2/attachment.bin>


More information about the llvm-commits mailing list