[PATCH] D141074: [X86] Avoid converting 64-bit integers to floating point using x87 on Windows

[icedrocket via Phabricator via llvm-commits]

icedrocket added a comment.

The reason I posted a review was because the conversion results from u64 and i64 to f32 did not match, causing problems.

I think using the x87 implementation of UINT_TO_FP also in i64 to f32 conversion is an alternative solution without compromising performance on Windows 32-bit. This is same behavior as MSVC and will solve the problem that prompted me to post this review. There may be a very slight drop in precision, but it shouldn't be a major issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141074/new/

https://reviews.llvm.org/D141074