[PATCH] D141752: [AVR] Fix an issue of writing 16-bit ports

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 14 01:07:46 PST 2023


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRExpandPseudoInsts.cpp:1275
+  bool XMega =
+      ELF::EF_AVR_ARCH_XMEGA1 <= ELFArch && ELFArch <= ELF::EF_AVR_ARCH_XMEGA7;
 
----------------
I like this form

`Low bound` <= `variable` && `variable` <= `high bound`.

Rather then 

`variable' <= `Low bound` && `variable` <= `high bound`.

which looks like `variable` is in range [low, high].


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141752/new/

https://reviews.llvm.org/D141752



More information about the llvm-commits mailing list