[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 15:08:25 PST 2023


chapuni added a comment.

This failed on some environments. See https://lab.llvm.org/buildbot/#/builders/109/builds/55534



================
Comment at: clang/test/Frontend/stack-layout-remark.c:24
+// YAML: Name:            StackLayout
+// YAML: DebugLoc:        { File: '{{.*}}stack-layout-remark.c', Line: [[# @LINE + 24]],
+// YAML: Function:        foo
----------------
`Line:` might be fed to the next line. I suggest;

```
// YAML: DebugLoc:        { File: '{{.*}}stack-layout-remark.c',{{[:space:]}}Line: [[# @LINE + 24]],
```


================
Comment at: clang/test/Frontend/stack-layout-remark.c:224
+// YAML: Name:            StackLayout
+// YAML: DebugLoc:        { File: '{{.*}}stack-layout-remark.c', Line: [[# @LINE + 59]]
+// YAML: Function:        caller
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488



More information about the llvm-commits mailing list