[PATCH] D140908: [MemProf] Context disambiguation cloning pass [patch 1/3]

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/PGHOContextDisambiguation.cpp:774
+  Visited.clear();
+  Propagate(LastNode, /*TowardsCallee*/ false, StackSequenceContextIds, Visited,
+            Propagate);
----------------
missing = in the comment, i.e. /*TowardsCallee=*/
There are a few other cases in this patch.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html


================
Comment at: llvm/lib/Transforms/IPO/PGHOContextDisambiguation.cpp:805
+    if (TowardsCallee) {
+      auto *NewEdge = new ContextEdge(Edge->Callee, NewNode,
+                                      computeAllocType(NewEdgeContextIds),
----------------
Can we use shared_ptr for the edges so that we don't have to manually track ownership?

(also mentioned in the other patch)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140908/new/

https://reviews.llvm.org/D140908