[PATCH] D136392: [Bazel] Use `LLVM_VERSION` from `llvm/CMakeLists.txt`

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 11:13:47 PST 2023


MaskRay accepted this revision.
MaskRay added inline comments.


================
Comment at: utils/bazel/configure.bzl:75
+def _extract_cmake_settings(repository_ctx, llvm_cmake):
+
+    # The list to be written to vars.bzl
----------------
Nit: We don't add a blank line after `def`:


================
Comment at: utils/bazel/configure.bzl:131
+def _write_dict_to_file(repository_ctx, filepath, header, vars):
+
+    # (fci + individual vars) + (fcd + dict items) + (fct)
----------------
Nit: We don't add a blank line after `def`:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136392/new/

https://reviews.llvm.org/D136392



More information about the llvm-commits mailing list