[PATCH] D140643: AMDGPU: Remove invalid testcase for enqueue kernel

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D140643#4029383 <https://reviews.llvm.org/D140643#4029383>, @rampitec wrote:

> In D140643#4028853 <https://reviews.llvm.org/D140643#4028853>, @arsenm wrote:
>
>> In D140643#4023847 <https://reviews.llvm.org/D140643#4023847>, @rampitec wrote:
>>
>>> It seems to remove the test when a caller is in a called function, because the called function is a kernel. But should it be an another function it shall be valid, yet I do not see such test. This is in fact what it would become after kernel call lowering. It seems worth to add such test with a non-kernel caller.
>>
>> We probably should have a separate phase ordering test for the current scheme, which is not what we have here. However, I'm working on a patch to move this into clang since the comment at the top of the file explaining why this is impossible is wrong
>
> But the test for a call for a non-inlined regular function is still needed regardless of pass ordering.

It doesn't matter after D141701 <https://reviews.llvm.org/D141701>, this callgraph analysis is broken anyway


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140643/new/

https://reviews.llvm.org/D140643