[PATCH] D141436: AMDGPU: Fix format string indexes for existing llvm.printf.fmts

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 10:17:51 PST 2023


arsenm closed this revision.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:170
+  NamedMDNode *metaD = M.getOrInsertNamedMetadata("llvm.printf.fmts");
+  unsigned UniqID = metaD->getNumOperands() - 1;
 
----------------
For some reason this indexing scheme starts at one, so this is off by one


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141436/new/

https://reviews.llvm.org/D141436



More information about the llvm-commits mailing list