[PATCH] D141599: [RISCV] Generalize performFP_TO_INTCombine to vectors

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 09:20:03 PST 2023


luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:9513
+
+  if (VT.isVector()) {
+    MVT SrcVT = Src.getSimpleValueType();
----------------
craig.topper wrote:
> You're only handling f16->i16 f32->i32 and f64->i64, but you didn't check that the integer size is the same as FP.
Whoops, presumably this means that we can handle f16 -> i32 with `vfwcvt.xu.f.v`, f32 -> i16 with `vfncvt.xu.f.v` and so on?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141599/new/

https://reviews.llvm.org/D141599



More information about the llvm-commits mailing list