[PATCH] D141692: [AArch64] Add tests for dotreduce to check for wider vectors.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 09:16:16 PST 2023


fhahn added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/neon-dotreduce.ll:10
+declare i32 @llvm.vector.reduce.add.v64i32(<64 x i32>)
+declare i32 @llvm.vector.reduce.add.v65i32(<65 x i32>)
 
----------------
this will generate a massive amount of code, so it might be better to just keep the one with 33 elements.


================
Comment at: llvm/test/CodeGen/AArch64/neon-dotreduce.ll:575
+
+define i32 @test_udot_v33i8_nomla(ptr nocapture readonly %a1) {
+; CHECK-LABEL: test_udot_v33i8_nomla:
----------------
What's the intention of the  `_nomla` tests? In those cases, no `dot` instructions can be selected in any case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141692/new/

https://reviews.llvm.org/D141692



More information about the llvm-commits mailing list