[PATCH] D141587: Add default constructurs to `filter_iterator_impl` and `filter_iterator_impl`.

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 09:15:35 PST 2023


ilya-biryukov added a comment.

Slight NIT: we might want to initialize `End` and `iterator_adaptor_base::I` with `WrappedIteratorT End = WrappedIteratorT()` to avoid uninitialized data members when `WrappedIteratorT` is a pointer.
This does not happen in practice right now, but if someone actually starts using this constructor in the future, we will at least not have UB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141587/new/

https://reviews.llvm.org/D141587



More information about the llvm-commits mailing list