[PATCH] D141417: [DirectX backend] emit metadata for DXIL version

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 08:05:16 PST 2023


beanz added inline comments.


================
Comment at: llvm/lib/Target/DirectX/DXILMetadata.h:35
 
-void createShaderModelMD(Module &M);
+void createShaderModelAndDXILVersionMD(Module &M);
 void createEntryMD(Module &M, const uint64_t ShaderFlags);
----------------
Since these are unrelated metadata entries, it makes more sense to do them in separate methods.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141417/new/

https://reviews.llvm.org/D141417



More information about the llvm-commits mailing list