[PATCH] D140460: [RISCV][MC] Add support for experimental zfa extension

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 07:33:05 PST 2023


reames added a comment.

This change is missing a few required bits:

- An update to RISCVUsage.rst
- The attribute tests in clang and llvm.  (See https://reviews.llvm.org/D133239 for an example.)

I agree with @craig.topper that splitting this into two patches makes sense.  Let's leverage experimental status to make our lives easier.



================
Comment at: llvm/lib/Target/RISCV/RISCV.td:130
+    : SubtargetFeature<"experimental-zfa", "HasStdExtZfa", "true",
+                       "'Zfa' (Half-Precision Floating-Point)",
+                       [FeatureStdExtF]>;
----------------
Description string is wrong here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140460/new/

https://reviews.llvm.org/D140460



More information about the llvm-commits mailing list