[PATCH] D139209: [IRMover] Remove UB implying parameter attributes when necessary

[Tim Neumann via Phabricator via llvm-commits]

TimNN added inline comments.


================
Comment at: llvm/lib/Linker/IRMover.cpp:1577-1579
+  if (DstF && SrcF && DstF->isDeclaration() && !SrcF->isDeclaration()) {
+    assert(DstF->arg_size() == SrcF->arg_size() &&
+           "Dst and Src should have the same signature.");
----------------
arsenm wrote:
> TimNN wrote:
> > arsenm wrote:
> > > I thought we casted the function type at callsites for different signatures in different modules, so this wouldn't hold?
> > @tejohnson do you have any input on this?
> > 
> > (I last looked at this code in-depth in early December, but don't remember seeing anything relevant. `ninja check-all` is also clean and in a brief test `IRMover` would happily import a function with a different signature without creating any bitcasts).
> These days it would appear as a callsite with a different type from the callee, there's no explicit bitcast with opaque pointers
Ack, then I guess the "brief test" wasn't really useful.

Anyway, if it is indeed expected that `SrcF` and `DstF` have different signatures here, I'd appreciate some guidance on how to best detect and handle that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139209/new/

https://reviews.llvm.org/D139209