[PATCH] D141576: [CodeGen] Prevent overlapping subregs in getCoveringSubRegIndexes

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 07:21:21 PST 2023


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetRegisterInfo.cpp:580
+
+      // Try to cover as much of the remaining lanes as possible.
+      const int Cover = (SubRegMask & LanesLeft).getNumLanes();
----------------
s/as much/as many/


================
Comment at: llvm/test/CodeGen/AMDGPU/extend-phi-subrange-not-in-parent.mir:61
     %0:vgpr_32 = IMPLICIT_DEF
     %1:vreg_1024_align2 = IMPLICIT_DEF
     %2:vreg_1024_align2 = COPY %1
----------------
Needs a new test for the cases that were failing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141576/new/

https://reviews.llvm.org/D141576



More information about the llvm-commits mailing list