[PATCH] D139209: [IRMover] Remove UB implying parameter attributes when necessary

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Linker/IRMover.cpp:1561
       for (Instruction &I : BB)
         if (CallInst *CI = dyn_cast<CallInst>(&I))
           CI->removeFnAttr(Attribute::NoCallback);
----------------
Drive by comment, but is this brokenly not checking for CallBase?


================
Comment at: llvm/test/Transforms/FunctionImport/Inputs/attr_fixup_dae_noundef.ll:6
+
+define void @outer(i32 noundef %0) {
+  ; The parameter was originally `noundef %0`, changed to `poison` by "deadargelim".
----------------
Shouldn't use anonymous values in tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139209/new/

https://reviews.llvm.org/D139209