[PATCH] D141657: [X86] Prefer fpext(splat(X)) to splat(fpext(x)).

[Freddy, Ye via Phabricator via llvm-commits]

FreddyYe updated this revision to Diff 488963.
FreddyYe marked an inline comment as done.
FreddyYe added a comment.

Rebase pre-commit test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141657/new/

https://reviews.llvm.org/D141657

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.h
  llvm/test/CodeGen/X86/prefer-fpext-splat.ll


Index: llvm/test/CodeGen/X86/prefer-fpext-splat.ll
===================================================================
--- llvm/test/CodeGen/X86/prefer-fpext-splat.ll
+++ llvm/test/CodeGen/X86/prefer-fpext-splat.ll
@@ -4,9 +4,7 @@
 define <4 x double> @prefer(float* %p) {
 ; CHECK-LABEL: prefer:
 ; CHECK:       # %bb.0: # %entry
-; CHECK-NEXT:    vmovss {{.*#+}} xmm0 = mem[0],zero,zero,zero
-; CHECK-NEXT:    vcvtss2sd %xmm0, %xmm0, %xmm0
-; CHECK-NEXT:    vbroadcastsd %xmm0, %ymm0
+; CHECK-NEXT:    vcvtps2pd (%rdi){1to4}, %ymm0
 ; CHECK-NEXT:    retq
 entry:
   %0 = load float, float* %p, align 4
Index: llvm/lib/Target/X86/X86ISelLowering.h
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.h
+++ llvm/lib/Target/X86/X86ISelLowering.h
@@ -1091,6 +1091,8 @@
         unsigned OldShiftOpcode, unsigned NewShiftOpcode,
         SelectionDAG &DAG) const override;
 
+    bool preferScalarizeSplat(unsigned Opc) const override;
+
     bool shouldFoldConstantShiftPairToMask(const SDNode *N,
                                            CombineLevel Level) const override;
 
Index: llvm/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -6012,6 +6012,10 @@
   return NewShiftOpcode == ISD::SHL;
 }
 
+bool X86TargetLowering::preferScalarizeSplat(unsigned Opc) const {
+  return Opc != ISD::FP_EXTEND;
+}
+
 bool X86TargetLowering::shouldFoldConstantShiftPairToMask(
     const SDNode *N, CombineLevel Level) const {
   assert(((N->getOpcode() == ISD::SHL &&


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141657.488963.patch
Type: text/x-patch
Size: 1661 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230113/1100c45b/attachment.bin>