[llvm] d5bee44 - [TableGen] Use raw_ostream::write_escaped instead of reinventing it. NFCI.

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 13 03:32:21 PST 2023


Author: Jay Foad
Date: 2023-01-13T11:14:06Z
New Revision: d5bee4432509d6e50540f614d07bf2991b2e6d59

URL: https://github.com/llvm/llvm-project/commit/d5bee4432509d6e50540f614d07bf2991b2e6d59
DIFF: https://github.com/llvm/llvm-project/commit/d5bee4432509d6e50540f614d07bf2991b2e6d59.diff

LOG: [TableGen] Use raw_ostream::write_escaped instead of reinventing it. NFCI.

Added: 
    

Modified: 
    llvm/utils/TableGen/SequenceToOffsetTable.h

Removed: 
    


################################################################################
diff  --git a/llvm/utils/TableGen/SequenceToOffsetTable.h b/llvm/utils/TableGen/SequenceToOffsetTable.h
index 1b3451c24cb08..77a404d07b7d3 100644
--- a/llvm/utils/TableGen/SequenceToOffsetTable.h
+++ b/llvm/utils/TableGen/SequenceToOffsetTable.h
@@ -26,48 +26,6 @@
 namespace llvm {
 extern llvm::cl::opt<bool> EmitLongStrLiterals;
 
-// Helper function for SequenceToOffsetTable<string>.
-static inline void printStrLitEscChar(raw_ostream &OS, char C) {
-  const char *Escapes[] = {
-      "\\000", "\\001", "\\002", "\\003", "\\004", "\\005", "\\006", "\\007",
-      "\\010", "\\t",   "\\n",   "\\013", "\\014", "\\r",   "\\016", "\\017",
-      "\\020", "\\021", "\\022", "\\023", "\\024", "\\025", "\\026", "\\027",
-      "\\030", "\\031", "\\032", "\\033", "\\034", "\\035", "\\036", "\\037",
-      " ",     "!",     "\\\"",  "#",     "$",     "%",     "&",     "'",
-      "(",     ")",     "*",     "+",     ",",     "-",     ".",     "/",
-      "0",     "1",     "2",     "3",     "4",     "5",     "6",     "7",
-      "8",     "9",     ":",     ";",     "<",     "=",     ">",     "?",
-      "@",     "A",     "B",     "C",     "D",     "E",     "F",     "G",
-      "H",     "I",     "J",     "K",     "L",     "M",     "N",     "O",
-      "P",     "Q",     "R",     "S",     "T",     "U",     "V",     "W",
-      "X",     "Y",     "Z",     "[",     "\\\\",  "]",     "^",     "_",
-      "`",     "a",     "b",     "c",     "d",     "e",     "f",     "g",
-      "h",     "i",     "j",     "k",     "l",     "m",     "n",     "o",
-      "p",     "q",     "r",     "s",     "t",     "u",     "v",     "w",
-      "x",     "y",     "z",     "{",     "|",     "}",     "~",     "\\177",
-      "\\200", "\\201", "\\202", "\\203", "\\204", "\\205", "\\206", "\\207",
-      "\\210", "\\211", "\\212", "\\213", "\\214", "\\215", "\\216", "\\217",
-      "\\220", "\\221", "\\222", "\\223", "\\224", "\\225", "\\226", "\\227",
-      "\\230", "\\231", "\\232", "\\233", "\\234", "\\235", "\\236", "\\237",
-      "\\240", "\\241", "\\242", "\\243", "\\244", "\\245", "\\246", "\\247",
-      "\\250", "\\251", "\\252", "\\253", "\\254", "\\255", "\\256", "\\257",
-      "\\260", "\\261", "\\262", "\\263", "\\264", "\\265", "\\266", "\\267",
-      "\\270", "\\271", "\\272", "\\273", "\\274", "\\275", "\\276", "\\277",
-      "\\300", "\\301", "\\302", "\\303", "\\304", "\\305", "\\306", "\\307",
-      "\\310", "\\311", "\\312", "\\313", "\\314", "\\315", "\\316", "\\317",
-      "\\320", "\\321", "\\322", "\\323", "\\324", "\\325", "\\326", "\\327",
-      "\\330", "\\331", "\\332", "\\333", "\\334", "\\335", "\\336", "\\337",
-      "\\340", "\\341", "\\342", "\\343", "\\344", "\\345", "\\346", "\\347",
-      "\\350", "\\351", "\\352", "\\353", "\\354", "\\355", "\\356", "\\357",
-      "\\360", "\\361", "\\362", "\\363", "\\364", "\\365", "\\366", "\\367",
-      "\\370", "\\371", "\\372", "\\373", "\\374", "\\375", "\\376", "\\377"};
-
-  static_assert(sizeof Escapes / sizeof Escapes[0] ==
-                    std::numeric_limits<unsigned char>::max() + 1,
-                "unsupported character type");
-  OS << Escapes[static_cast<unsigned char>(C)];
-}
-
 static inline void printChar(raw_ostream &OS, char C) {
   unsigned char UC(C);
   if (isalnum(UC) || ispunct(UC)) {
@@ -184,9 +142,7 @@ class SequenceToOffsetTable {
        << Decl << " = {\n";
     for (auto I : Seqs) {
       OS << "  /* " << I.second << " */ \"";
-      for (auto C : I.first) {
-        printStrLitEscChar(OS, C);
-      }
+      OS.write_escaped(I.first);
       OS << "\\0\"\n";
     }
     OS << "};\n"


        


More information about the llvm-commits mailing list