[PATCH] D141662: [MLIR][memref] Add details on the semantic of reinterpret_cast

Fri Jan 13 02:21:36 PST 2023

qcolombet added inline comments.

================
Comment at: mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td:1259
+    ```
+    means that `%dst`'s descriptor will be:
+    ```mlir
----------------
mehdi_amini wrote:
> In general I believe we avoided defining the memref semantics in terms of "descriptor" which was intended as one possible LLVM lowering (so an implementation detail basically).
> 
> (I'm not sure if the doc is still decoupled though)
Ah shoot, I already pushed the change.
How do you recommend that we amend this change?

Leaving out the "In other words[...]" part that breaks down the memref descriptor?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141662/new/

https://reviews.llvm.org/D141662