[PATCH] D86578: [TargetLowering] Combine known bits for icmp in SimplifySetCC (PR41182)

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:3640-3642
+      if (Optional<bool> IsEQ = KnownBits::eq(LHSKnown, RHSKnown))
+        return DAG.getBoolConstant(IsEQ.getValue(), dl, VT, OpVT);
+      break;
----------------
Just put `Result = KnownBits::whatever(LHSKnown, RHSKnown)` inside the switch, and sink the `if (Result) return ...` out?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86578/new/

https://reviews.llvm.org/D86578