[PATCH] D141479: [RISCV] Generate march string from target features

[Wang Pengcheng via Phabricator via llvm-commits]

pcwang-thead marked 2 inline comments as done.
pcwang-thead added inline comments.


================
Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:39
+    if (llvm::RISCVISAInfo::isSupportedExtensionFeature(FeatureName))
+      FeatureVector.push_back((Twine("+") + FeatureName).str());
+  }
----------------
fpetrogalli wrote:
> Nit - maybe if you set `std::vector<StringRef> FeatureVector;` you can avoid the `.str()` in here?
I'm afraid not, because we expect `std::vector<std::string>` in `llvm::RISCVISAInfo::parseFeatures`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141479/new/

https://reviews.llvm.org/D141479