[PATCH] D141479: [RISCV] Generate march string from target features
Wang Pengcheng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 13 02:04:10 PST 2023
pcwang-thead marked 2 inline comments as done.
pcwang-thead added inline comments.
================
Comment at: llvm/utils/TableGen/RISCVTargetDefEmitter.cpp:39
+ if (llvm::RISCVISAInfo::isSupportedExtensionFeature(FeatureName))
+ FeatureVector.push_back((Twine("+") + FeatureName).str());
+ }
----------------
fpetrogalli wrote:
> Nit - maybe if you set `std::vector<StringRef> FeatureVector;` you can avoid the `.str()` in here?
I'm afraid not, because we expect `std::vector<std::string>` in `llvm::RISCVISAInfo::parseFeatures`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141479/new/
https://reviews.llvm.org/D141479
More information about the llvm-commits
mailing list