[PATCH] D141196: [cmake] Don't require third-party components when cross-compiling

[James Le Cuirot via Phabricator via llvm-commits]

chewi added a comment.

I'd like to keep it as it is

I'm not sure if you meant dynamically checking for anything beginning with `LLVM_INCLUDE_`. While that is possible, it relies on a CMake feature that is really meant for debugging. I'd also need to avoid `LLVM_INCLUDE_DIR(S)` which is used for something else.

Even then, I think hard-disabling is safer than passing through. If we know these things aren't needed then disabling them means less chance of something going wrong. What is one of them requires a library you don't have on your build host?

So I was going to hard-disable the others, but I think you'd actually need `UTILS` and possibly `TOOLS`. I doubt the others would impact the build time, as I think it only builds the things you need anyway. `BENCHMARKS` and `TESTS` are just special cases because the third-party directory needs to exist at configure time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141196/new/

https://reviews.llvm.org/D141196