[PATCH] D141619: [GVN] Refactor handling of pointer-select in GVN pass

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Thanks! Could you please also split off the change to findDominatingLoad()? For that change, we also need to introduce a limit on the number of instructions that get walked while finding the dominating value (100 would be consistent with MemDep), otherwise there may be issues with very large blocks. There should also be a test that shows we can now handle a case that we previously couldn't (with the dominating load being in a preceding basic block).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141619/new/

https://reviews.llvm.org/D141619