[PATCH] D141469: [AArch64][SVE] Add more intrinsics in 'isZeroingInactiveLanes'.

Thu Jan 12 23:13:52 PST 2023

dewen marked an inline comment as done.
dewen added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:305
+    case Intrinsic::aarch64_sve_uzp2:
+    case Intrinsic::aarch64_sve_sel:
+    case Intrinsic::aarch64_sve_orr_z:
----------------
dewen wrote:
> dewen wrote:
> > sdesmalen wrote:
> > > Predicate select is slightly different, since there is only a full-vector predicate select (operating on svbool_t), so there are no inactive lanes. It might be worth to point that out in a comment.
> > > 
> > > Can you please add a test for this case? it seems to be missing.
> > Okay, thank you. @sdesmalen
> I have updated. Please review. @sdesmalen
hi, @sdesmalen, thanks for you review. Could you please review it again?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141469/new/

https://reviews.llvm.org/D141469