[PATCH] D141196: [cmake] Don't require third-party components when cross-compiling

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 21:47:33 PST 2023


xen0n added a comment.

Thanks for the patch!

The change seems okay in this case, though I wonder if passing through all other `LLVM_INCLUDE_*` parameters could be cleaner in principle, instead of hard-disabling. (I know the NATIVE build isn't meant to be used in a way that requires those optional components e.g. benchmarks, examples, runtimes to be enabled, but IMO passing through is less of a special-case than overriding in general.)

OTOH while at it I think you could add the other `LLVM_INCLUDE_*` as well, for better future-proofing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141196/new/

https://reviews.llvm.org/D141196



More information about the llvm-commits mailing list