[PATCH] D141607: [RISCV] Optimize (brcond (seteq (and X, (1 << C)-1), 0))

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 19:53:44 PST 2023


craig.topper added a comment.

LGTM with that fix.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1549
+        ShAmt = LHS.getValueSizeInBits() - 1 - Log2_64(Mask);
+      } else
+        ShAmt = LHS.getValueSizeInBits() - (64 - countLeadingZeros(Mask));
----------------
Add curly braces around the `else` body to match the `if`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141607/new/

https://reviews.llvm.org/D141607



More information about the llvm-commits mailing list