[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

Thu Jan 12 16:38:17 PST 2023

nickdesaulniers added a comment.

In D135488#4049075 <https://reviews.llvm.org/D135488#4049075>, @thegameg wrote:

> You can easily...

I'll just note that v1 of this patch IIRC was a note on the single individual instance of the `-Wframe-larger-than=` diagnostic.  No additional flags for optimization remarks, no (large) dump of stack frame info for non-interesting functions, no python module writing necessary.

I recognize that this approach is a compromise, and it's not worth going back and forth.

But the point of this is to simplify the developer experience when `-Wframe-larger-than=` is encountered. Let's not lose sight of that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135488/new/

https://reviews.llvm.org/D135488