[PATCH] D141548: [AMDGPU][NFC] Heterogeneous DWARF extensions update

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

LGTM save a few nits/questions



================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:3612
+
+1.  A ``DW_AT_location attribute``, whose value is a DWARF expression E that
+    describes the location of a variable or parameter at run-time.
----------------
This "attribute" is outside of the code-backticks in other places, did you intend to put it inside here?


================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:3722
+
+  This section, augments DWARF Version 5 section 5.3.
+
----------------
This comma seems extraneous


================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:4702
+
+      - The first type of reference...
+
----------------
I assume this is saying "the rest of the existing DWARF5 text as-is"?


================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:4704
+
+      - The second type of reference can identify any debugging information
+        entry within a .debug_info section; in particular, it may refer to an
----------------
This is just removing the text "For references from one shared object or static executable file to another, the relocation and identification of the target object must be performed by the consumer", right? Is this because it is redundant (and covered by the non-normative notes)?


================
Comment at: llvm/docs/AMDGPUDwarfExtensionsForHeterogeneousDebugging.rst:4897
+
+   ================================== =======
+   ``DW_AT_LLVM_address_space``
----------------
Is the second column required for this to parse, or to match the two-column layout in the spec?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141548/new/

https://reviews.llvm.org/D141548