[PATCH] D141487: [LoopUnroll] Directly update DT instead of DTU.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 14:11:20 PST 2023


kuhar added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/Local.h:504
+/// removed or if the DT for its predecessors changed.
+void updateDominatorTreeUsingPredecessors(BasicBlock *BB, DominatorTree *DT);
+
----------------
Also, could we have some unit tests? I'm thinking about both having some concrete examples that we can look at and possibly death test to make sure that the assertions catch what we wanted to assume.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141487/new/

https://reviews.llvm.org/D141487



More information about the llvm-commits mailing list