[PATCH] D140922: [VE] Fix useDeprecatedPositionallyEncodedOperands errors.

Kazushi Marukawa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 14:08:26 PST 2023


kaz7 requested changes to this revision.
kaz7 added a comment.
This revision now requires changes to proceed.

Thank you very much for updating VEInstInfo.td and fixing CVTRDm problem.  I have only one comment.



================
Comment at: llvm/lib/Target/VE/VEInstrInfo.td:854
   let DecoderMethod = "DecodeBranchCondition" in
-  defm r : BCtgm<opcStr, "$comp, ", opc, (ins CCOp:$cond, RC:$comp)>;
+  defm r : BCtgm<opcStr, "$sy, ", opc, (ins CCOp:$cf, RC:$sy)>;
   let DecoderMethod = "DecodeBranchCondition", cy = 0 in
----------------
Is it possible to not convert "cond" to "cf" please?  We use "cond" as condition flag several times in VEInstrInfo.td, so I'd like to make them consitent, either "cond" or "cf".  Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140922/new/

https://reviews.llvm.org/D140922



More information about the llvm-commits mailing list