[PATCH] D141458: [X86] Add RMPQUERY to SNP instructions

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrSNP.td:43
+// F3 0F 01 FD
+let Uses = [RAX, RDX], Defs = [RCX, RDX] in
+def RMPQUERY: I<0x01, MRM_FD, (outs), (ins), "rmpquery", []>, XS,
----------------
craig.topper wrote:
> Defs doesn't reflect this additional sentence from the spec
> 
> ```
> Upon completion, a return code is stored in EAX. rFLAGS bits OF, ZF, AF, PF and SF are set based on
> return code.
> ```
All the SNP instructions seem to be missing this in fact - and many update RAX/EAX with a return code as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141458/new/

https://reviews.llvm.org/D141458