[PATCH] D128813: [unknown_provenance] Verifier: check it only exists on the ptr_provenance path

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: llvm/test/Verifier/unknown_provenance.ll:2
+; RUN: not llvm-as %s -o /dev/null 2>&1 | FileCheck %s
+
+define ptr @test00(ptr %a, ptr %b, i32 %c) {
----------------
Could you add a comment for each of tests on the case being verified?


================
Comment at: llvm/test/Verifier/unknown_provenance.ll:35
+
+define void @test03(ptr %a, ptr %b, i32 %c) {
+entry:
----------------
nit: move tests 03 and 04 at the end as valid, following all invalid? Can a single `CHECK-NOT:` be used then for all valid tests?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128813/new/

https://reviews.llvm.org/D128813