[PATCH] D141628: [DirectX backend] support empty program signature parts for compute shader

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 12:49:06 PST 2023


beanz added a comment.

All the other changes going into the DXContainer object and yaml support are aiming to be more full featured, and the object and yaml tooling changes are separate from the implementation change.

Please follow that structure.



================
Comment at: llvm/include/llvm/BinaryFormat/DXContainer.h:133
+  uint32_t ParamOffset;
+  void swapBytes() {
+    sys::swapByteOrder(ParamCount);
----------------
nit: please add whitespace separating the members from the method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141628/new/

https://reviews.llvm.org/D141628



More information about the llvm-commits mailing list