[PATCH] D141565: [RISCV][CodeGen] Account for LMUL from VS2 for Vector Reduction Instructions

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 12:19:33 PST 2023


michaelmaitland added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoV.td:728
   def _VS : VALUVV<funct6, OPMVV, opcodestr # ".vs">,
-            Sched<[WriteVIRedV, ReadVIRedV, ReadVIRedV0, ReadVMask]>;
+            Sched<[WriteVIRedV_From_UpperBound, ReadVIRedV, ReadVIRedV0,
+                   ReadVMask]>;
----------------
Other LMUL specific `SchedWrite`s use the suffix `UpperBound`. Is there a difference in meaning between `UpperBound` and `From_UpperBound`?


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:3303
     defm _VS : VPseudoTernary<V_M1.vrclass, m.vrclass, V_M1.vrclass, m>,
-               Sched<[WriteVIRedV, ReadVIRedV, ReadVIRedV, ReadVIRedV, ReadVMask]>;
+               Sched<[WriteVIRedV_From_MX, ReadVIRedV, ReadVIRedV, ReadVIRedV,
+                      ReadVMask]>;
----------------
Other LMUL specific SchedWrites use the suffix `MX`. Is there a difference in meaning between `MX` and `From_MX`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141565/new/

https://reviews.llvm.org/D141565



More information about the llvm-commits mailing list