[PATCH] D141552: test-release.sh: Only build clang for stage1 and stage2

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 11:43:59 PST 2023


tstellar added a comment.

In D141552#4047517 <https://reviews.llvm.org/D141552#4047517>, @thieta wrote:

> I think we should include lld as well - now that LLD can produce production binaries on all platforms I think it makes sense to prefer that over system linker.

I think in addition to building lld, we would also have to add another cmake flag like -DLLVM_USE_LLD when configuring.  That might be worthy a separate change, since it will change the final output (whereas this  current change does not affect the final output at all).

> When we discussed this earlier I think we talked about only running the tests at the end the product. I still think it makes sense to not do the full testing in Phase 1/2, but other people can disagree with that if we think it will not catch issues.

It doesn't look like the tests currently run for stage 1 and stage 2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141552/new/

https://reviews.llvm.org/D141552



More information about the llvm-commits mailing list