[PATCH] D130746: RFC: Uniformity Analysis for Irreducible Control Flow

[Krzysztof Drewniak via Phabricator via llvm-commits]

krzysz00 added a comment.
Herald added a subscriber: StephenFan.

FYI, I'm seeing the following build failures with ROCm 5.4.0 Clang (so somewhere between Clang 15 and 16)  on Ubuntu 20.04 that arise from this patch. I don't know if these are a system configuration error or what but I thought I should post them here

  [build] FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineUniformityAnalysis.cpp.o 
  [build] /opt/rocm/llvm/bin/clang++  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/CodeGen -I/home/kdrewnia/llvm-project/llvm/lib/CodeGen -Iinclude -I/home/kdrewnia/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -g    -fno-exceptions -fno-rtti -std=c++17 -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineUniformityAnalysis.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineUniformityAnalysis.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachineUniformityAnalysis.cpp.o -c /home/kdrewnia/llvm-project/llvm/lib/CodeGen/MachineUniformityAnalysis.cpp
  [build] In file included from /home/kdrewnia/llvm-project/llvm/lib/CodeGen/MachineUniformityAnalysis.cpp:9:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/CodeGen/MachineUniformityAnalysis.h:17:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/GenericUniformityInfo.h:16:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/GenericCycleInfo.h:31:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/ArrayRef.h:13:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/SmallVector.h:28:
  [build] In file included from /usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/memory:83:
  [build] /usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/unique_ptr.h:357:2: error: static assertion failed due to requirement '__is_invocable<llvm::GenericUniformityInfo<llvm::GenericSSAContext<llvm::MachineFunction>>::ImplDeleter &, llvm::GenericUniformityAnalysisImpl<llvm::GenericSSAContext<llvm::MachineFunction>> *>::value': unique_ptr's deleter must be invocable with a pointer
  [build]         static_assert(__is_invocable<deleter_type&, pointer>::value,
  [build]         ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  [build] /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/GenericUniformityInfo.h:41:3: note: in instantiation of member function 'std::unique_ptr<llvm::GenericUniformityAnalysisImpl<llvm::GenericSSAContext<llvm::MachineFunction>>, llvm::GenericUniformityInfo<llvm::GenericSSAContext<llvm::MachineFunction>>::ImplDeleter>::~unique_ptr' requested here
  [build]   GenericUniformityInfo(FunctionT &F, const DominatorTreeT &DT,
  [build]   ^
  [build] In file included from /home/kdrewnia/llvm-project/llvm/lib/CodeGen/MachineUniformityAnalysis.cpp:9:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/CodeGen/MachineUniformityAnalysis.h:17:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/GenericUniformityInfo.h:16:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/GenericCycleInfo.h:31:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/ArrayRef.h:13:
  [build] In file included from /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/SmallVector.h:28:
  [build] In file included from /usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/memory:83:
  [build] /usr/lib/gcc/x86_64-linux-gnu/10/../../../../include/c++/10/bits/unique_ptr.h:454:2: error: static assertion failed due to requirement '__is_invocable<llvm::GenericUniformityInfo<llvm::GenericSSAContext<llvm::MachineFunction>>::ImplDeleter &, llvm::GenericUniformityAnalysisImpl<llvm::GenericSSAContext<llvm::MachineFunction>> *>::value': unique_ptr's deleter must be invocable with a pointer
  [build]         static_assert(__is_invocable<deleter_type&, pointer>::value,
  [build]         ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  [build] /home/kdrewnia/llvm-project/llvm/include/llvm/ADT/GenericUniformityImpl.h:1179:6: note: in instantiation of member function 'std::unique_ptr<llvm::GenericUniformityAnalysisImpl<llvm::GenericSSAContext<llvm::MachineFunction>>, llvm::GenericUniformityInfo<llvm::GenericSSAContext<llvm::MachineFunction>>::ImplDeleter>::reset' requested here
  [build]   DA.reset(new ImplT{Func, DT, CI, TTI});
  [build]      ^
  [build] 2 errors generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130746/new/

https://reviews.llvm.org/D130746