[PATCH] D141585: [RISCV] Custom lower vector ISD::CTLZ to the minimum of ISD::CTLZ_ZERO_UNDEF and element size.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 11:18:11 PST 2023


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM with those comments fixed.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3606
+      DAG.getNode(ISD::SUB, DL, VT, DAG.getConstant(Adjust, DL, VT), Exp);
+  // The above result with zero input is equaled to Adjust which greater than
+  // EltSize. Hence, we can do min(Res, EltSize) for CTLZ.
----------------
equaled -> equal

"which greater" -> "which is greater"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141585/new/

https://reviews.llvm.org/D141585



More information about the llvm-commits mailing list