[PATCH] D141622: [lit] don't skip test times when executions are instantaneous

[Ashay Rane via Phabricator via llvm-commits]

ashay-github created this revision.
ashay-github added reviewers: stella.stamenova, csigg, bkramer.
Herald added a subscriber: delcypher.
Herald added a project: All.
ashay-github requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

If a test executes quickly or if the timing resolution is too coarse,
the running time associated with a test could be zero.  This happens
often for the //llvm/utils/lit/tests/reorder.py test on Windows, which
causes the test to fail non-deterministically.

This patch modifies the existing check, so that instead of skipping
zeros, lit now skips if the timing is `None` (presumably due to an error
in measurement).  Recurring executions of the reorder.py test on Windows
seem to indicate that the test no longer exhibits occasional failure.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D141622

Files:
  llvm/utils/lit/lit/TestTimes.py


Index: llvm/utils/lit/lit/TestTimes.py
===================================================================
--- llvm/utils/lit/lit/TestTimes.py
+++ llvm/utils/lit/lit/TestTimes.py
@@ -19,7 +19,7 @@
     times_by_suite = {}
     for t in tests:
         assert t.suite.test_times is None
-        if not t.result.elapsed:
+        if t.result.elapsed is None:
             continue
         if not t.suite.exec_root in times_by_suite:
             times_by_suite[t.suite.exec_root] = read_test_times(t.suite)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D141622.488713.patch
Type: text/x-patch
Size: 507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230112/939f3774/attachment.bin>