[PATCH] D137707: Move "auto-init" instructions to the dominator of their users
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 12 10:13:22 PST 2023
nickdesaulniers added a comment.
Sorry for the delay in testing this. Do you mind rebasing it? `arc patch D137707` is having a hard time applying it to ToT.
The test cases LGTM but I'd like @efriedma to review the memory ordering stuff; I don't understand that stuff as much as I would like to.
================
Comment at: llvm/lib/Transforms/Utils/MoveAutoInit.cpp:161
+
+ for (auto Job : JobList) {
+ Job.first->moveBefore(Job.second);
----------------
Should we take a reference to the std::pair here? `auto &Job`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137707/new/
https://reviews.llvm.org/D137707
More information about the llvm-commits
mailing list