[PATCH] D127728: [BitcodeReader] Allow reading pointer types from old IR

[Jannik Silvanus via Phabricator via llvm-commits]

jsilvanus added a comment.

Thanks for the refactoring. One more thought inline.



================
Comment at: llvm/include/llvm/Bitcode/BitcodeReader.h:73
+struct ParserCallbacks {
+  std::optional<DataLayoutCallbackFuncTy> DataLayout;
+  /// The ValueType callback is called for every function definition or
----------------
Now that the callback itself is optional, and the callback receives the data layout that would be used if not for the callback,
I'd like to point out that we *could* let the callback return a string instead of an optional string.

I'd find that slightly better, but I'm not sure it's worth the trouble.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127728/new/

https://reviews.llvm.org/D127728