[PATCH] D141518: [AArch64] Move default extensions from clang Driver to TargetParser

Lucas Prates via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 09:33:36 PST 2023


pratlucas added a comment.

Sorry, I just noticed my previous comment wasn't clear on what I meant by passing on the target features.
The features are indeed included as part of the IR attributes since D141411 <https://reviews.llvm.org/D141411>, but they are no longer included as `-target-feature` arguments in calls to cc1 by the clang driver. This is not the case when using `-mcpu`, for example. 
I agree the end result will be the same assuming the information is consistent between the TargetParser and the backend's subtarget features, but I think it would be good to define the what's the clang driver's expected behaviour to avoid any inconsistencies in the future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141518/new/

https://reviews.llvm.org/D141518



More information about the llvm-commits mailing list