[PATCH] D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/utils/TableGen/Printer.h:74
+    for (unsigned I = Count; I > 0; --I)
+      OS << "\n";
+  }
----------------
Single quotes


================
Comment at: llvm/utils/TableGen/Printer.h:100
+  virtual void regInfoEmitSubRegIdxLists(
+      std::string const TargetName,
+      SequenceToOffsetTable<SubRegIdxVec, deref<std::less<>>> const
----------------
Should use StringRef for all these const string parameters


================
Comment at: llvm/utils/TableGen/PrinterLLVM.cpp:1419
+  OS << "  return BaseClasses[Mapping[Reg]];\n";
+  OS << "}\n";
+}
----------------
Don't need a separate OS << on each line, can just break the one literal across multiple lines


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138323/new/

https://reviews.llvm.org/D138323