[PATCH] D141518: [AArch64] Move default extensions from clang Driver to TargetParser

Lucas Prates via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 08:51:17 PST 2023


pratlucas added a comment.

It makes sense to move this to the TargetParser and the code looks much better indeed. My only concern is that this changes the driver's behaviour in regards to which target feature flags are passed from clang to the backend.

It looks like the implied features are included in the backend calls for the `-mcpu` options and, as far as I can tell, those are correctly captured from the TargetParser info. Should we do the same for `-march` values? Or should we rely strictly in the backend expansion?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141518/new/

https://reviews.llvm.org/D141518



More information about the llvm-commits mailing list