[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added a subscriber: rnk.
aaron.ballman added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:2479-2483
+#define WASM_REF_TYPE(InternalName, MangledName, Id, SingletonId, AS)          \
+  case BuiltinType::Id:                                                        \
+    Out << "PA";                                                               \
+    mangleArtificialTagType(TTK_Struct, MangledName);                          \
+    break;
----------------
I don't think the `PA` bit is correct -- that seems to be specific to OpenCL. So I think that bit can simply be dropped, but CC @rnk for questions about Microsoft ABI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122215/new/

https://reviews.llvm.org/D122215