[PATCH] D141289: [MIScheduler] Print top/down cycle in the SUnit dump.

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 06:44:39 PST 2023


fpetrogalli marked 2 inline comments as done.
fpetrogalli added inline comments.


================
Comment at: llvm/lib/CodeGen/ScheduleDAG.cpp:366
+    if (SchedPrintCycles)
+      dbgs() << " " << SU.TopReadyCycle << " " << SU.BotReadyCycle;
+    dbgs()<< ")";
----------------
fhahn wrote:
> Hmm, is there a reason for including it in the name and not including them among the attributes (`SUnit::dumpAttributes`)? There it would also be possible to print a name associated with the values.
It is because we want the information to be printed by `void ScheduleDAGMI::dumpSchedule() const`, so that we can check the last bits of the debug info of the machine scheduler right after the string `*** Final schedule for %bb.0 ***`.

As far as I understand `SUnit::dumpAttributes` is printed before the scheduler does its job. We need to check the two extra values when the scheduler has finished.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141289/new/

https://reviews.llvm.org/D141289



More information about the llvm-commits mailing list