[PATCH] D140799: [AMDGPU][AsmParser][NFC] Refine defining i8- and i16-typed custom operands.

Ivan Kosarev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 12 05:26:45 PST 2023


kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.td:1194
 
+class NamedOperandClass<string Prefix, string Name>
+    : CustomOperandClass<Name, 1> {
----------------
dp wrote:
> Are you going to further generalize this class?
> The name does not reflect limitations on the expected syntax (an int with prefix).
Would `NamedIntOperandClass` do?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140799/new/

https://reviews.llvm.org/D140799



More information about the llvm-commits mailing list