[PATCH] D141549: [X86] Add additional tests for ctlz{_zero_undef} to test folding with xor; NFC

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/clz.ll:626
 ; X86-NOCMOV-NEXT:    movl {{[0-9]+}}(%esp), %ecx
-; X86-NOCMOV-NOT:     rep
 ; X86-NOCMOV-NEXT:    bsfl {{[0-9]+}}(%esp), %edx
----------------
This seems manually mentained. Please keep it as it. The same for below changes.


================
Comment at: llvm/test/CodeGen/X86/clz.ll:1784
+
+define i32 @ctlz_xor31_i32_false(i32 %x) {
+; X86-LABEL: ctlz_xor31_i32_false:
----------------
Missing a `ctlz_xor31_i32_ture` unintentionally?
Actually, I think it's better if we intersect use `i8_true`, `i16_false` etc. to reduce the size. I'd prefer to use less tests while not compromise the cover rate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141549/new/

https://reviews.llvm.org/D141549