[PATCH] D141460: [bootstrap build] Add libc-hdrgen as a build dep for libc bootstrap build.

[Siva Chandra via Phabricator via llvm-commits]

sivachandra added inline comments.


================
Comment at: llvm/runtimes/CMakeLists.txt:362
                                       ${${name}_extra_args}
+                           PASSTHROUGH_PREFIXES ${ARG_PREFIXES}
                            EXTRA_TARGETS ${${name}_extra_targets}
----------------
phosek wrote:
> phosek wrote:
> > This can have potentially negative side-effects. Take for example Fuchsia's CMake cache file where on Darwin we set the [generic flags](https://github.com/llvm/llvm-project/blob/6aff41ef37a48461b85c4b5bb143fceec6130a55/clang/cmake/caches/Fuchsia-stage2.cmake#L50) which are passed to the "default" build as well as [prefixed flags](https://github.com/llvm/llvm-project/blob/6aff41ef37a48461b85c4b5bb143fceec6130a55/clang/cmake/caches/Fuchsia-stage2.cmake#L89) which are passed to target build. With this change, the generic flags will be passed to the target build and interfere with the prefixed flags. Can we avoid this change for now?
> > 
> To add some additional context, I'm planning major changes to how the "default" and target builds are set up, and after those changes, this should be possible without any negative side-effects, but that's going to take a few more weeks.
The other option is to detect the libc specific options and pass them as `CMAKE_ARGS`. For now, we only need to test for `LLVM_LIBC_FULL_BUILD`. If that is OK, then we can avoid depending on prefixes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141460/new/

https://reviews.llvm.org/D141460